Michał Krassowski

Results 562 issues of Michał Krassowski

Add tests for enrichment of overlaps: - `ComplexUpset:::test_set_overlaps` (not currently exported, but will become public in the future) - `ComplexUpset:::test_set_overlaps_of_degree` (internal)

The performance of manually specified intersections is not as good as it could be, and was degraded since #109 (which however, was needed as that fix corrects behaviour and protects...

enhancement

It's time to make the experience smoother for user when working with different related packages. See https://twitter.com/Lluis_Revilla/status/1337436516004605952

documentation

I would like to be able to make the upset quicker by not having to compute the names of the groups. For exmaple, given the movies data frame subset: ```R...

enhancement

This could be something adapting the patchwork semantics, like: ```R ( upset(movies, genres) / inter_property(aes(y=budget, color=length), geom='point') + scale_color_continuous(name='Movie length') / inter_size() / (group_size() | inter_matrix()) & query_iter(c('Drama', 'Comedy'), color='red',...

enhancement

The docs should have some real life examples to make the start easier for less experienced R/Python users (and for myself when I forget to use `pivot_table` instead of `pivot`...

For better compatibility with plots composition, ignore_tag should be set on the intersection matrix; it should be optional. An article om composing multiple upset plots should be also added.

Following up on [this comment](https://github.com/krassowski/complex-upset/issues/20#issuecomment-609072325) from @gofraidh, it would be good to consider adding an example, or even a helper function to make working with the data in a long...

enhancement

- [ ] on an existing annotation - [ ] with a dedicated annotation panel (intersection-matrix-like, but adding p-values and only showing significant rows)

Passing optional argument `add_caption=TRUE` could generate a caption such as: > Showing overlap > 10; There are 21 smaller overlaps that do not meet these criteria.

enhancement