kotest
kotest copied to clipboard
Improve stacktraces of shouldMatchEach
When using shouldMatchEach, the stacktraces only refer to this function, not to a particular failure. This change fixes that, so that:
- if there is a single failure, it merges the stacktraces
- if there are multiple failures, it explicitly puts the stacktraces into the string failures representations It is a draft for now, because:
- it changes the public api (didn't find a way how to do that without this change)
- it doesn't change all operators consistently, only one Any kind of feedback is welcome.
Is this ready to come out of draft?
Ok, rebased and moving out of draft. The concern "it doesn't change all operators consistently, only one" is still valid.
There are test failures, sorry about not fixing them immediately. I'll provide a fixed version in a few days.
Tests should be fixed.
Tried to fix the windows build.
As a result of my fix, I also broke macos build :( I'll try to find a solution for all platforms.
What's left to get this merged? Anything I can help with ?
Actually I forgot about it, I'll try to find some time to fix the missing piece in the following days.
Closing this one as it's a bit stale. Let us know if we should reopen
Yes, I don't have time to fix all platform-specific test failures. I'll reopen it if I find some time to do it. Anyone is welcome to do it, of course.