vue-goodshare

vue-goodshare copied to clipboard

There is incorrect usage of v-model in Facebook.vue: https://github.com/koddr/vue-goodshare/blob/73d146f6a9ec1507e9079ab99ccc81ef2760a858/src/providers/Facebook.vue#L17-L21

node_modules/vue-goodshare/src/providers/Facebook.vue:19:7
17 |      <span
18 |        class="counter-facebook"
19 |        v-model="counter_facebook"
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^
20 |        v-if="this.$props.has_counter"
21 |      >

webpack compiled with 2 errors

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template!

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

I can confirm that this issue is still relevant when using vue 3.2.39

I can confirm that this issue is still relevant when using vue 3.2.39

Hi,

Can you please try to another Vue.js version?

Hi,

Can you please try to another Vue.js version?

The error message was added three years ago, so I suppose it affects the versions that were released in the last 3 years.

v-model is a two-way binding and doesn't serve any purpose on a span. Having {{ counter_facebook }} will suffice to output the number.

I tried removing all v-model="counter_*" instances and everything works as intended.

Will you accept a PR removing the v-models?

+1 same issue here

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Yes it still exists. Vue version 3.3.2