docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix sequence with broker image to show correct filter

Open creydr opened this issue 3 years ago • 2 comments

In the sequence with broker docs, the following image is used to give an overview of the example sequence:

sequence example description

Anyhow in the examples later the trigger for the broker to the sequence, filters on type: dev.knative.sources.ping: https://github.com/knative/docs/blob/2d2d2f59117be87dc261ba7ba99190755d07cf1a/docs/eventing/flows/sequence/sequence-with-broker-trigger/README.md?plain=1#L172-L189

And the trigger for the event-display filters on type: samples.http.mod3: https://github.com/knative/docs/blob/2d2d2f59117be87dc261ba7ba99190755d07cf1a/docs/eventing/flows/sequence/sequence-with-broker-trigger/README.md?plain=1#L199-L226

This PR addresses it and updates the image to show the correct "types" for the filters.

creydr avatar Sep 22 '22 13:09 creydr

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 2d2d2f59117be87dc261ba7ba99190755d07cf1a
Latest deploy log https://app.netlify.com/sites/knative/deploys/632c65eabeafde000800bc70
Deploy Preview https://deploy-preview-5229--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 22 '22 13:09 netlify[bot]

@knative/eventing-wg-leads please review

abrennan89 avatar Sep 22 '22 17:09 abrennan89

Thank you @creydr for the fix, the new diagram is correct now /lgtm /approve

csantanapr avatar Sep 24 '22 00:09 csantanapr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, csantanapr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 24 '22 00:09 knative-prow[bot]