docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon knative

Qpextensions

Open davidhadas opened this issue 3 years ago • 3 comments

"Fixes #5170

Proposed Changes

  • Add documentation about Queue Proxy Extensions feature merge into Queue Proxy

davidhadas avatar Aug 10 '22 16:08 davidhadas

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit de5cbdca01dcec26e85e58d1e7df9c88d9f4b8f0
Latest deploy log https://app.netlify.com/sites/knative/deploys/6304625c42db380008464413
Deploy Preview https://deploy-preview-5169--knative.netlify.app/docs/serving/services/using-queue-extensions
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 16:08 netlify[bot]

/assign davidhadas

davidhadas avatar Aug 10 '22 17:08 davidhadas

/cc @abrennan89

davidhadas avatar Aug 15 '22 14:08 davidhadas

It looks like at https://pkg.go.dev/knative.dev/security-guard/pkg/qpoption this is actually named "Queue Proxy Option" rather than "Queue Proxy Extension". Please rename it across the doc so that it's consistent, i.e. use Queue Proxy Option since that's the actual feature name, otherwise this could cause confusion.

abrennan89 avatar Aug 17 '22 16:08 abrennan89

@davidhadas left some comments for now, will provide a second review once some of these are fixed

/hold

abrennan89 avatar Aug 17 '22 17:08 abrennan89

Looks good to me. @abrennan89 will do her second review and then we can get this merged. 🙂

snneji avatar Aug 19 '22 18:08 snneji

@snneji I'll leave it to you to merge this one if you're happy with it

abrennan89 avatar Aug 22 '22 19:08 abrennan89

/lgtm /approve

snneji avatar Aug 23 '22 09:08 snneji

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidhadas, snneji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Aug 23 '22 09:08 knative-prow[bot]