community icon indicating copy to clipboard operation
community copied to clipboard

Change the account for Knative prow robot.

Open vaikas opened this issue 4 years ago • 10 comments

Currently: https://github.com/knative-prow-robot

Belongs to google.com domain. As discussed on 2021-02-03 and 2021-02-11 SC meeting, there is no reason for this, and @thisisnotapril has done some investigation into the matter and k8s for example has set this up so that various folks have access to the robot (not sure of the details). This would make it easier for external folks like @n3wscott to be able to attend to more matters pertaining to prow troubleshooting, as well as fixing issues as they come up.

So, this issue should track figuring out how do we move the account over and who (most natural would probably be productivity WG leads) should have access to the robot, etc.

I'm assigning this to @thisisnotapril and @n3wscott to sort out what needs to be done, how to do it. Feel free to delegate as necessary :)

vaikas avatar Feb 11 '21 18:02 vaikas

@n3wscott @thisisnotapril any updates on this?

vaikas avatar Mar 18 '21 16:03 vaikas

@n3wscott could we take the Knative prow infra and move it from the current GCP-owned repo to a Knative repo? Then our permissions would apply. We'd need to update where Prow looks for our config; I am assuming (hopefully not too radically) that would be an easy change.

thisisnotapril avatar Mar 31 '21 23:03 thisisnotapril

Let's try to make this move on 2021-04-12 and see what all breaks and then decide if we should continue or revert. @n3wscott @thisisnotapril

vaikas avatar Apr 01 '21 16:04 vaikas

Let's wait on this until after the .23 release since we do not have cycles to deal with this, nor is this the biggest problem we're dealing with at the moment.

vaikas avatar Apr 15 '21 16:04 vaikas

We decided to push this to post 1.0

bsnchan avatar Jun 10 '21 16:06 bsnchan

@thisisnotapril @n3wscott is this something that we might now be able to tackle? How does (if at all) this relate to the new CLA work also going on.

vaikas avatar Nov 04 '21 16:11 vaikas

I sure could, what is the new CLA work? I don't know that one.

n3wscott avatar Nov 04 '21 17:11 n3wscott

We need to figure out the plan here; my naive assumption is that this was simply a password associated with the GitHub user named knative-prow-robot. I think we need to figure out some way to escrow these credentials and figure out who has access to that secret.

evankanderson avatar Dec 06 '21 22:12 evankanderson

(There's also a published email for this account, but that should be possible to change.)

evankanderson avatar Dec 06 '21 22:12 evankanderson

There are some other robots that we could probably remove from the org: google-prow-robot, k8s-ci-robot.

evankanderson avatar Dec 06 '21 22:12 evankanderson

@upodroid @kvmware ping - can this be moved to productivity?

lance avatar Feb 02 '23 17:02 lance

I can login to the bot and change its email to [email protected] so the account is owned by the community.

I'll do this next week. I might need to speak to the Googlers who can access the old mailing list.

upodroid avatar Feb 02 '23 17:02 upodroid

/assign @upodroid

lance avatar Feb 02 '23 21:02 lance

@upodroid Do you have any updates on this?

@lance do you know what happened to knative.team domain?

nainaz avatar Mar 09 '23 17:03 nainaz

@nainaz the knative.team domain should still exist - I am able to login using my account for that domain.

lance avatar Mar 16 '23 21:03 lance

Need to assign it to Productivity group.

nainaz avatar Jun 05 '23 16:06 nainaz

I fixed this today. https://github.com/knative/community/pull/1374

/close

upodroid avatar Jun 05 '23 16:06 upodroid

@upodroid: Closing this issue.

In response to this:

I fixed this today. https://github.com/knative/community/pull/1374

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Jun 05 '23 16:06 knative-prow[bot]

Actually one of the robot accounts was fixed. I need to fix the other one too.

upodroid avatar Jun 05 '23 16:06 upodroid

@knative/productivity-leads should this be in your wheelhouse instead of steering?

lance avatar Jun 05 '23 16:06 lance

I think if it has to do with billing or membership it should be steering otherwise probably us

krsna-m avatar Jun 05 '23 16:06 krsna-m

This is done now.

https://github.com/knative-prow-robot https://github.com/knative-prow-updater-robot

upodroid avatar Jun 06 '23 09:06 upodroid