community
community copied to clipboard
Update MATURITY-LEVELS.md to have concrete coverage level
Changes
This is a proposal to add the coverage level for Usable and Stable components. Even if the levels are not ok, we should be explicit about how much coverage is required for both levels of maturity.
- :gift: add link to codecov example and add 50% coverage level for Usable components.
- :gift: add link to codecov example and add 70% coverage level for Stable components.
/kind enhancement
It doesn't fix an issue because this is an update on the maturity levels that needs to be discussed with Steering. I couldn't find any other doc where these coverage levels are mentioned, as they are only configured in codecov.
Release Note
Docs
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: salaboy
Once this PR has been reviewed and has the lgtm label, please assign evankanderson for approval by writing /assign @evankanderson in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm /hold for discussion with @knative/technical-oversight-committee and/or @knative/steering-committee
I like this additions. what's the latest status to merge this? @lance @salaboy
I'm ok with the levels proposed. Should we set a target date for meeting those thresholds so that components have time to meet the new standards if they aren't already (if that's even an issue)?
I'm ok with the levels proposed. Should we set a target date for meeting those thresholds so that components have time to meet the new standards if they aren't already (if that's even an issue)?
I think that would be good. I know functions appears to have very low coverage - lower than required. However, this is (I think) primarily due to the fact that we have a suite of tests that are not getting reported in the coverage results. It will take some small amount of effort to get that worked out, but it's been a pretty low priority.
Does by the next release (v1.9 on Jan 24, 2023) sound like a good deadline?
Does by the next release (v1.9 on Jan 24, 2023) sound like a good deadline?
Yes absolutely - we are currently about 0.3% away from "Usable".
Does by the next release (v1.9 on Jan 24, 2023) sound like a good deadline?
Yes absolutely - we are currently about 0.3% away from "Usable".
Now at 57% and rising! :)
@salaboy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-knative-extensions-peribolos | c26c14bd007d9371bba7484b525f9ee43fd4425b | link | true | /test pull-knative-extensions-peribolos |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@salaboy you still working on this?
cc @knative/steering-committee
Going to close this out
cc @knative/technical-oversight-committee in case you have opinions - feel free to create a new PR