community icon indicating copy to clipboard operation
community copied to clipboard

Update MATURITY-LEVELS.md to have concrete coverage level

Open salaboy opened this issue 3 years ago • 10 comments

Changes

This is a proposal to add the coverage level for Usable and Stable components. Even if the levels are not ok, we should be explicit about how much coverage is required for both levels of maturity.

  • :gift: add link to codecov example and add 50% coverage level for Usable components.
  • :gift: add link to codecov example and add 70% coverage level for Stable components.

/kind enhancement

It doesn't fix an issue because this is an update on the maturity levels that needs to be discussed with Steering. I couldn't find any other doc where these coverage levels are mentioned, as they are only configured in codecov.

Release Note


Docs


salaboy avatar Sep 12 '22 08:09 salaboy

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: salaboy Once this PR has been reviewed and has the lgtm label, please assign evankanderson for approval by writing /assign @evankanderson in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Sep 12 '22 08:09 knative-prow[bot]

/lgtm /hold for discussion with @knative/technical-oversight-committee and/or @knative/steering-committee

lance avatar Sep 12 '22 11:09 lance

I like this additions. what's the latest status to merge this? @lance @salaboy

csantanapr avatar Oct 06 '22 16:10 csantanapr

I'm ok with the levels proposed. Should we set a target date for meeting those thresholds so that components have time to meet the new standards if they aren't already (if that's even an issue)?

psschwei avatar Oct 06 '22 19:10 psschwei

I'm ok with the levels proposed. Should we set a target date for meeting those thresholds so that components have time to meet the new standards if they aren't already (if that's even an issue)?

I think that would be good. I know functions appears to have very low coverage - lower than required. However, this is (I think) primarily due to the fact that we have a suite of tests that are not getting reported in the coverage results. It will take some small amount of effort to get that worked out, but it's been a pretty low priority.

lance avatar Oct 07 '22 15:10 lance

Does by the next release (v1.9 on Jan 24, 2023) sound like a good deadline?

psschwei avatar Oct 07 '22 16:10 psschwei

Does by the next release (v1.9 on Jan 24, 2023) sound like a good deadline?

Yes absolutely - we are currently about 0.3% away from "Usable".

lance avatar Oct 10 '22 12:10 lance

Does by the next release (v1.9 on Jan 24, 2023) sound like a good deadline?

Yes absolutely - we are currently about 0.3% away from "Usable".

Now at 57% and rising! :)

lance avatar Oct 14 '22 16:10 lance

@salaboy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-extensions-peribolos c26c14bd007d9371bba7484b525f9ee43fd4425b link true /test pull-knative-extensions-peribolos

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knative-prow[bot] avatar Aug 01 '23 22:08 knative-prow[bot]

@salaboy you still working on this?

cc @knative/steering-committee

dprotaso avatar Sep 15 '23 14:09 dprotaso

Going to close this out

cc @knative/technical-oversight-committee in case you have opinions - feel free to create a new PR

dprotaso avatar Mar 14 '24 22:03 dprotaso