Christian Klemm

Results 63 comments of Christian Klemm
trafficstars

From a user's perspective `IMatToaster` definitely should be thread safe. Looking at the [current implementation](https://github.com/SamProf/MatBlazor/blob/77eb54b9c32f5de676ca3b80a54b512385bc7b5c/src/MatBlazor/Services/Toast/MatToaster.cs#L20) you can see it isn't at all. I would grab this issue if I'm allowed...

Facing the same problem on 1.5.0 `Use of unassigned local variable 'typeName' (Source code: typeName)` ```c# public static string GetGenericTypeName(this Type type) { string typeName; if (type.IsGenericType) { var genericTypes...

> One possible approach is make the BindingContext property public and [Parameter], and make its auto-resolve lazy, so the parent component have a chance to specify the child component's BindingContext...

> Should the auto-resolve be lazy or should we keep the SetBindingContext call in the OnInitialized method (i.e. the BindingContext can only be set externally before the component is initialized)?...

> If I'm not mistaken, the view model is set right in the constructor, so it's always present. This only applies for the internal constructor that is used for testing....

I definitely understand the need for alternatives since I'm not happy with the current situation either. The main reason for this pattern was proper support for `IDisposable` because otherwise the...

Looks good to me, I'm gonna make a deep dive into this topic on the weekend. However, we need to ensure a solution that is non-breaking. I don't want to...

I made my thoughts about your solutions: - New `ServiceProvider` implementation: this would be highly intrusive and also could be a problem when people want to use a different IoC...

> Mainly, I am not sure of the behavior that my implementation have (or even the one that it should have!) when services are injected in cascade (should the attribute...

Cascading parameters are supported. Could you create a minimal reproduction to show the exact issue? Keep in mind that you need to declare such parameters in both the component and...