kiwix-android
kiwix-android copied to clipboard
CI job for detecting kotlin Version
Fixes #2892
a) In this PR we are generating Kotlin report by buildKotlinToolingMetadata gradle task then we check the Kotlin version used in project if its 1.7.0 then CI will work otherwise leads to failure.
Codecov Report
Merging #2893 (10fee35) into develop (1d31abe) will decrease coverage by
0.07%. The diff coverage isn/a.
@@ Coverage Diff @@
## develop #2893 +/- ##
=============================================
- Coverage 43.03% 42.96% -0.08%
Complexity 25 25
=============================================
Files 289 289
Lines 9143 9143
Branches 928 928
=============================================
- Hits 3935 3928 -7
- Misses 4836 4842 +6
- Partials 372 373 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...iwixmobile/language/viewmodel/LanguageViewModel.kt | 92.68% <0.00%> (-7.32%) |
:arrow_down: |
| ...org/kiwix/kiwixmobile/language/LanguageFragment.kt | 68.51% <0.00%> (-5.56%) |
:arrow_down: |
| ...org/kiwix/kiwixmobile/intro/CustomPageIndicator.kt | 80.49% <0.00%> (-0.25%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1d31abe...10fee35. Read the comment docs.
How works this PR?
- Codefactor is red
- Does it systematically check code against Kotlin 1.7.0?
- Does it makes the CI red if not?
- Where is the result of this check reported? I see nothing in the CI of the PR?
- Please put a small description in the PR
a) Checking code refactor. b) Yes buildKotlinToolingMetadata building all code and placed the report inside build folder. c) Yes i have placed the failure check on shell script it will exit the the build job. d) please check https://github.com/kiwix/kiwix-android/runs/7210304356?check_suite_focus=true e) ok
I don't know if this is possible to do better, but this is not really user friendly.
I don't know if this is possible to do better, but this is not really user friendly.
hi @kelson42 do you have any idea what addition i can do to make it better ?
I'm not sure, why we are checking the kotlin version in our CI?
@gouri-panda It should be the code which is checked, not the version.