kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Removed All Memory leaks from Custom app

Open gouri-panda opened this issue 3 years ago • 7 comments

Fixes #2617

gouri-panda avatar May 20 '22 13:05 gouri-panda

Codecov Report

Merging #2844 (176a3b5) into develop (1165354) will decrease coverage by 1.17%. The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             develop    #2844      +/-   ##
=============================================
- Coverage      45.37%   44.20%   -1.18%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9491     9493       +2     
  Branches         976      976              
=============================================
- Hits            4307     4196     -111     
- Misses          4783     4890     +107     
- Partials         401      407       +6     
Impacted Files Coverage Δ
...g/kiwix/kiwixmobile/core/main/KiwixTextToSpeech.kt 19.82% <50.00%> (-0.35%) :arrow_down:
...org/kiwix/kiwixmobile/core/zim_manager/TagsView.kt 0.00% <0.00%> (-88.24%) :arrow_down:
...org/kiwix/kiwixmobile/core/zim_manager/KiloByte.kt 0.00% <0.00%> (-85.72%) :arrow_down:
.../kiwixmobile/core/downloader/model/Base64String.kt 0.00% <0.00%> (-75.00%) :arrow_down:
.../kiwixmobile/core/extensions/TextViewExtensions.kt 0.00% <0.00%> (-60.00%) :arrow_down:
...imManager/libraryView/adapter/LibraryViewHolder.kt 0.00% <0.00%> (-38.89%) :arrow_down:
.../zimManager/libraryView/adapter/LibraryDelegate.kt 55.55% <0.00%> (-38.89%) :arrow_down:
.../kiwix/kiwixmobile/core/main/TableDrawerAdapter.kt 48.93% <0.00%> (-38.30%) :arrow_down:
...kiwixmobile/core/extensions/ImageViewExtensions.kt 0.00% <0.00%> (-33.34%) :arrow_down:
...e/zimManager/libraryView/adapter/LibraryAdapter.kt 75.00% <0.00%> (-25.00%) :arrow_down:
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar May 20 '22 13:05 codecov[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 18:06 stale[bot]

@gouri-panda This is a promising branch, do you plan to conplete it in a near future?

kelson42 avatar Jun 20 '22 07:06 kelson42

Yes @kelson42 . I'll complete this soon.

gouri-panda avatar Jun 20 '22 08:06 gouri-panda

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jul 10 '22 21:07 stale[bot]

@gouri-panda Any news here? I would like to merge what as been fixed so far in 3.6.0 and close the PR.

kelson42 avatar Jul 26 '22 17:07 kelson42

@kelson42 Sure :) sorry for this delay :(. I'll finish all my pending PRs.

gouri-panda avatar Jul 28 '22 13:07 gouri-panda

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 10:08 stale[bot]

@gouri-panda This is the only memory leak in custom apps? Is that only in custom apps?

kelson42 avatar Sep 05 '22 19:09 kelson42

@kelson42 I renamed the PR. It's not a good idea to fix in one PR. We'll find other leaks and fix it individually.

gouri-panda avatar Sep 05 '22 19:09 gouri-panda

@gouri-panda Is this memory leak specific to custom apps?

kelson42 avatar Sep 07 '22 07:09 kelson42

@kelson42 No, it's generic.

gouri-panda avatar Sep 07 '22 10:09 gouri-panda

Can you rephrase the ticket and PR then? This is misleading.

kelson42 avatar Sep 07 '22 10:09 kelson42

Can you rephrase the ticket and PR then? This is misleading.

The generic meaning it's happening in our test custom app, so we assume all the customs apps.

gouri-panda avatar Sep 07 '22 10:09 gouri-panda

No, I mean why the PR title is "Removed TextInputSpeech memory leaks from Custom app" when it should be "Removed TextInputSpeech memory leaks"?

kelson42 avatar Sep 07 '22 11:09 kelson42