kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

WikiHow zim files are definitely not using the correct logos / icons

Open kelson42 opened this issue 3 years ago • 19 comments
trafficstars

From wikihow created by Popolechien: openzim/wikihow#104

Screenshot wikiHow

kelson42 avatar Dec 27 '21 15:12 kelson42

Shouldn't it be in wikihow repo ?

kelson42 avatar Dec 27 '21 15:12 kelson42

Sorry you'll have to move it again

kelson42 avatar Dec 27 '21 15:12 kelson42

Could we fix it by forcing the wikiHow logo into the recipe?

kelson42 avatar Dec 27 '21 15:12 kelson42

But it looks like a reader/catalog issue actually as those icons are not random from the ZIM but from other ZIMs

kelson42 avatar Dec 27 '21 15:12 kelson42

It's probably because wikihow ZIMs uses new Illustration and no favicon

kelson42 avatar Dec 27 '21 15:12 kelson42

So I'd say it's a reader issue

kelson42 avatar Dec 27 '21 15:12 kelson42

Which ZIM file is that? Do we know if this is a problem in the library.xml or in Kiwix-Android?

kelson42 avatar Dec 27 '21 15:12 kelson42

@Popolechien thx.

kelson42 avatar Dec 27 '21 15:12 kelson42

Not sure how much of a reader issue that is: I'm looking at library.kiwix.org (kiwix-serve) and the WikiHow zim files show no icon at all. Capture d’écran 2021-11-25 à 12 19 56

kelson42 avatar Dec 27 '21 15:12 kelson42

@kelson42 Not sure we can move the issue across projects (from openzim/wikihow to kiwix/kiwix-android)

kelson42 avatar Dec 27 '21 15:12 kelson42

I will move the ticket to kiwix/kiwix-android

kelson42 avatar Dec 27 '21 15:12 kelson42

@rgaudin yes, even 3 times now and my question stay unanswered. I need the exact filename to make my assessment.

I don't know what else to say. Those ZIM have Illustration_48x48 and thus no -/favicon entry. The library XML doesn't exposes those icons so there is no favicon property in those nodes.

kiwix-serve 3.1.2-5 understands there is no icon and thus displays no icon. We're aware of this ; it was discussed back in August. kiwix-android apparently isn't expecting this situation and is probably displaying an icon from the next/previous available node.

Possible immediate fix: change the tool that generates the library.xml so it sets the favicon property from Illustration if there's no -/favicon.

FYI, libzim7 (at least pylibzim) doesn't allow specifying a namespace so we can't add a -/favicon entry to those ZIM, should we want to.

kelson42 avatar Dec 27 '21 15:12 kelson42

@kelson42 There has only been one run so the files and file names are those in https://download.kiwix.org/zim/wikihow/

wikihow_pt_maxi_2021-10.zim wikihow_nl_maxi_2021-10.zim wikihow_es_maxi_2021-10.zim wikihow_ko_maxi_2021-10.zim

Interestingly, here is another screenshot of the same series taken at a different time - the icons have changed compared to my earlier screenshot: Screenshot_20211125-223320

kelson42 avatar Dec 27 '21 15:12 kelson42

@rgaudin yes, even 3 times now and my question stay unanswered. I need the exact filename to make my assessment.

kelson42 avatar Dec 27 '21 15:12 kelson42

For some reason this ticket does not move... but it should. Config looks good.

kelson42 avatar Dec 27 '21 15:12 kelson42

/move to kiwix/kiwix-android

kelson42 avatar Dec 27 '21 15:12 kelson42

Could we fix it by forcing the wikiHow logo into the recipe?

No. The scraper already gets the proper icon and sets it properly. It's a new ZIM, using the new Illustration_ metadata for the Icon. The problem is that the reader, which uses previous version is not aware of this. You'll notice that old kiwix-serve doesn't displays it either while the current one (on dev-library) does.

kelson42 avatar Dec 27 '21 15:12 kelson42

Which ZIM file is that? Do we know if this is a problem in the library.xml or in Kiwix-Android?

have you read my comments ?

kelson42 avatar Dec 27 '21 15:12 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 06:04 stale[bot]

hi @kelson42 ,

This issue seems rectify by using lib 10.1.1 for WikiHow , i am attaching the current screenshot but if favicon is not available then its pick's up the icon of next or previous list item.

wikiHow Search Download screen
Screenshot_2022-09-23-12-43-09-694_org kiwix kiwixmobile Screenshot_2022-09-23-12-43-31-308_org kiwix kiwixmobile

MohitMaliFtechiz avatar Sep 23 '22 07:09 MohitMaliFtechiz

@MohitMaliFtechiz Good news. I think a PR is need to fix the following points:

  • If no illustration availabl, display default logo https://fileproinfo.com/file-type/zim#
  • Stop displaying wrong logo (of precent file).
  • I have seen the bug in the bookmark view yesterday, so check there as well.

kelson42 avatar Sep 25 '22 10:09 kelson42