kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Showing a dialog when clicked on close server

Open cdhiraj40 opened this issue 3 years ago • 5 comments

Checklist for requesting a feature:

  • [x] Check the issue tracker. The feature you are requesting may have already been requested.
  • [x] Check if the feature does not exist on the latest developer's version.

Is your feature request related to a problem? Please describe. when closing the server it directly closes it and it may have happened by mistake. As it closes the server immediately the reading sessions in other devices, Having a dialog asking for close may help in fixing that.

Describe the solution you'd like when clicked on stop server, a dialogue should show to ask to close the server. something like this:

Screenshot_2021-12-23-15-00-46-23_924282dd390cc14aae1af1e29436bb16.jpg

I would like to work on this :)

cdhiraj40 avatar Dec 23 '21 09:12 cdhiraj40

can i work on this issue

Rishavgupta12345 avatar Jan 07 '22 04:01 Rishavgupta12345

@Rishavgupta12345 it's not discussed yet. @cdhiraj40 I don't think it's necessary. User can simply reconnecting the service by clicking one button(Start Server) and the other side of the device or user won't even notice if they are static. @kelson42 What do you think?

gouri-panda avatar Jan 10 '22 12:01 gouri-panda

@Rishavgupta12345 it's not discussed yet. @cdhiraj40 I don't think it's necessary. User can simply reconnecting the service by clicking one button(Start Server) and the other side of the device or user won't even notice if they are static. @kelson42 What do you think?

if it works like that then i agree on this being unnecessary but i would still like to check once and inform you again.

cdhiraj40 avatar Jan 10 '22 13:01 cdhiraj40

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 06:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]

I confirm, such a dialog seems unecessary.

kelson42 avatar Feb 02 '23 16:02 kelson42