eloquent-power-joins icon indicating copy to clipboard operation
eloquent-power-joins copied to clipboard

Published 20 hours ago • verified publisher icon kirschbaum-development

chore: add some strict types

Open GeoSot opened this issue 2 years ago • 2 comments

Just another one quality scoped PR. Adding some typed properties and return types, plus two deletions that are pointed below

@luisdalmolin is up to your decision, again

GeoSot avatar Jul 06 '23 23:07 GeoSot

@GeoSot Sorry for the long time to merge this, but if you want to fix the merge conflicts, we can merge this.

luisdalmolin avatar Oct 22 '23 13:10 luisdalmolin

It's fine @luisdalmolin.

Later you may take a look on \Kirschbaum\PowerJoins\Mixins\RelationshipsExtraMethods::getFarParent . It seems unused

GeoSot avatar Oct 22 '23 19:10 GeoSot