Alexey Kucherenko

Results 32 issues of Alexey Kucherenko

### Motivation I'd like to add a simple module that provided with healthcheck functionality (actually, it's part of integration testing for ripple qewd microservices). The module should look very simple:...

Hey @robtweed Simple test `should be able to send message using websockets`: ```js describe('custom message', () => { let data; beforeEach((done) => { request. post('/ajax'). send({ type: 'ewd-register', application: 'test-app'...

Hi @robtweed Please consider the following lines: https://github.com/robtweed/qewd/blob/cbf87ac9cbb0eaed5ae663f3c1607aaffad2f05d/lib/master-express.js#L95-L102 Some notes: 1. I'm not sure that `beforeRouter`/`afterRouter` must be validated to be an array because concat works fine if passed argument...

Hi @robtweed Please take a look https://github.com/robtweed/qewd/blob/cbf87ac9cbb0eaed5ae663f3c1607aaffad2f05d/lib/sockets.js#L72-L77 if data is null, the code will fail on line 76

Hey @robtweed Environment: - express - gtm Please take a look: https://github.com/robtweed/qewd/blob/cbf87ac9cbb0eaed5ae663f3c1607aaffad2f05d/lib/appHandler.js#L292 I found that app crushed on this line with error: I think this line should be replaced to...

https://github.com/jhnns/rewire/pull/116 https://github.com/jhnns/rewire/issues/101

https://github.com/robtweed/qewd/blob/6b9b898a3be2d5134c38561e7fc7522c347b11bf/lib/appHandler.js#L43-L45 to ```js if (!appModule.handlers) appModule.handlers = {}; this.handlers[application] = appModule.handlers; ``` because `if (appModule.handlers)` on line 45 is always true

Hi @robtweed If we take a look at `no docment store` logic, we can see that it uses `customError` function https://github.com/robtweed/qewd/blob/master/lib/appHandler.js#L113-L119 However, if we take a look at `session is...