frappe-better-list-view

frappe-better-list-view copied to clipboard

parser function is working as expected ON INITIAL LOAD of a listview BUT NOT after the following scenarios:

1. listview refresh icon is clicked
2. list item is clicked on and followed to another page, then browser back button is used to return to the listview
3. list item is clicked on and followed ... then listview breadcrumb is clicked to return to the listview basically under the above failure scenarios, the parser function IS NOT EXECUTED, so some mechanism is needed to execute the parser under the above conditions.

NOTE: listview before_render() function IS CALLED under each of the above scenario's, but I haven't been able to find a way to retrigger the parser function from the before_render() function.

@spkarjalainen Thanks a lot buddy for reporting this bug..

Is there any error in the browser console log?

I will look into your suggestion and get back to you..

Best regards..

@spkarjalainen Hey buddy..

I have a question for you..

In all the above scenarios, is the parser function in the listview settings the only thing that doesn't work? Or there are other things too?

I have figured out what might cause the parser not to work in the above scenarios..

Best regards..

Hey Ameen,

The parser is the only component I'm using at present (I was testing your project out for the first time in ERPNext v14.x). Everything else appeared to be working correctly, but I'm not in front of the computer at the so cannot verify.

Cheers, Sam

On Wed, Oct 11, 2023, 11:29 PM Ameen Ahmed @.***> wrote:

@kid1194 https://github.com/kid1194 Hey buddy..

I have a question for you..

In all the above scenarios, is the parser function in the listview settings the only thing that doesn't work? Or there are other things too?

I have figured out what might cause the parser not to work in the above scenarios..

Best regards..

— Reply to this email directly, view it on GitHub https://github.com/kid1194/frappe-better-list-view/issues/6#issuecomment-1757961786, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDF7XWCWTFGASWOFW37IVITX623OHANCNFSM6AAAAAA53OKVPA . You are receiving this because you were mentioned.Message ID: @.***>

@spkarjalainen Thanks a lot Sam for your reply..

Since the parser function is the only part with this issue, then I think that it will work fine in the latest update..

Please note that I have done some changes to the parser function option..

So please give the latest update a try, if you can, and let me know how it goes..

Best regards..

Hi Ameen,

Thanks! I am on leave now for two weeks so I will give it a test once I'm back at work.

Kind regards Sam

On Fri, Oct 13, 2023, 1:20 AM Ameen Ahmed @.***> wrote:

@spkarjalainen https://github.com/spkarjalainen Thanks a lot Sam for your reply..

Since the parser function is the only part with this issue, then I think that it will work fine in the latest update..

So please give the latest update a try, if you can, and let me know how it goes..

Best regards..

— Reply to this email directly, view it on GitHub https://github.com/kid1194/frappe-better-list-view/issues/6#issuecomment-1760040528, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDF7XWE5HF4OYHFLJNMUTYDX7ARGXAVCNFSM6AAAAAA53OKVPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRQGA2DANJSHA . You are receiving this because you were mentioned.Message ID: @.***>

@spkarjalainen Hey Sam..

It's OK bro, just enjoy your leave 😁

Best regards..