keystone icon indicating copy to clipboard operation
keystone copied to clipboard

make context config in ApolloServer config works

Open bichikim opened this issue 3 years ago • 3 comments

🤣

bichikim avatar Mar 02 '22 02:03 bichikim

🦋 Changeset detected

Latest commit: ea612116fa96c1322747df21d60e33caaea6290b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-ui/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 02 '22 02:03 changeset-bot[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9DQtu88rjc2VD9H9qSSbG8JmUPXA
✅ Preview: https://keystone-next-docs-git-fork-bichikim-update-a-63a6b4-keystonejs.vercel.app

vercel[bot] avatar Mar 02 '22 02:03 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Mar 02 '22 02:03 codesandbox-ci[bot]

Hi @bichikim,

Thanks for the pull request, I think this highlights a problem we need to fix, but maybe not exactly like this pull request. I think I see two options

  1. Restrict the Typescript types to not include an Apollo context, and update our documentation
  2. Alternatively, add or merge the Apollo context into our own Keystone context

dcousens avatar Aug 15 '22 03:08 dcousens