keycloak-nodejs-connect

keycloak-nodejs-connect copied to clipboard

Some Types are missing in the current implementation. Related Jira-Issue: https://issues.redhat.com/browse/KEYCLOAK-14578

Looks like there are a few more changes in PR #245. So I'd say whatever works best for the reviewers. If the other changes are valid too, I can cherry-pick the respective commits into this PR.

@beevelop if you are ok about this idea, let's do this. We cherry-pick changes from #245 keeping the authorship and update this pull-request with your commit. Thank you!

Typescript won't work with this package, maybe it's better to remove .d.ts completely until it's covered by unit tests.

What's the workaround for using this package with typescript in the meantime?

What's the workaround for using this package with typescript in the meantime?

I've created a gulp task to replace the definition file in the node_modules folder with a modified one.

Hi and thanks for reporting,I've got an other similar issue! it's hard to find useful information about this issue since the typescript config KeycloakConfig is missing the realm-public-key prop already ! So that's what i get with both version ^11.0.3 and the actual one ^12.0.4:

  interface KeycloakConfig {
    'confidential-port': string|number
    'auth-server-url': string
    'resource': string
    'ssl-required': string
    'bearer-only'?: boolean
    realm: string
  }

So in my case i can use the missing declared property: 'realm-public-key': 'pemkey', while ignoring the ts checking. I will create a separate issue for this but i think that's important to list in this thread since its similar to the issue subject.

What is the current status for Typescript support and what was the blocker on this PR?