Kevin Mårtensson

Results 104 comments of Kevin Mårtensson

Yeah, is `module.parent.filename` reliable to use to get caller modules `package.json`?

I'm finishing up my rewrite of this module as we speak so should be able to close this soon.

@sindresorhus, apart from #37, are there any other things you see can be improved regarding the API?

So instead of defining `.dest()` it could check for `bin` in the package.json and use that path? Sounds good to me.

It has to match the one defined in `.use()` though if you were to create multiple binaries like we do in elm-platform. In other words, the binary name must be...

Yeah, that's probably a good idea. Not a big fan of including logging stuff though.

I think `sudo` is required to be able to run it on Linux regardless. There's an open PR which addresses this https://github.com/kevva/brightness/pull/11.

You have to set `protocol: https` if you're accessing a HTTPS page. Otherwise it looks fine. If you don't set the proxy, it'll try to get it from environment flags.

I guess you're looking for the `keepAlive` option https://nodejs.org/api/http.html#http_new_agent_options?