Kevin Leung

Results 283 comments of Kevin Leung

I don't think type parameter on components would be supported in the current implementation. For one you can't run `entity.get(Velocity)` to get the component. Because at runtime you can't distinguish...

As I said you can't distinguish the type parameters at run time. So that `entity.get()` will not work. And because of that, at lot of things won't work downstream, including...

I just had a look on it. Looks like it is only benchmarking one thing: iterate all entities and perform some task on their components. On my macbook running the...

Yes, 2x as fast Though I can barely test on nodejs because the benchmark framework seems broken

It is iterating an array now: https://github.com/kevinresol/ecs/blob/9ad36a0/src/ecs/node/NodeList.hx#L72 But I need to re-emphasize that the optimizing on a single part of the codebase doesn't mean much. While iteration is faster, add/remove...

would adding a special @:op rule work? ```haxe // put this before `eq` @:op(A==B) public inline function eqNullable(o:Null):Bool ... ```

This looks more like a Haxe problem. I am not sure how to deal with `Null` in abstract operator overloads...

SyntheticEvent is also used in react native but no DOM stuff there

I think both implementation are similar. But iirc at runtime SyntheticEvent is actually a "class" instead of a plain anon object. And I think both `target` and `nativeEvent` should be...

https://github.com/kevinresol/hxnodejs-jsonwebtoken