Keith Winstein

Results 156 comments of Keith Winstein

Closing as dormant (it looks like we decided not to do this).

@pouyakary Thank you (belatedly) for this PR! I don't know what happened when it was submitted (I suspect either nobody had the cycles to review it, or we may also...

In the interests of trying to clean up the PR backlog -- is there still interest in pursuing this (subject to comments) or is this ok to close?

These warnings seem to have been fixed, and WABT is now built (at least in CI) with `-Werror` (https://github.com/WebAssembly/wabt/pull/1185#issuecomment-1216990255).

Hi -- is there still interest in merging this (in which case I think the diff should probably be cleaned up to avoid re-formatting those big sections), or should we...

I think the root cause might be something like, "The SSE2 floating-point instructions largely conform to IEEE 754 (and the Wasm semantics wrt canonical/arithmetic NaNs), but x87 doesn't. So if...

It's cool that Fedora's building WABT with those CFLAGS, but to get the wasm2c tests to build _their_ output with those CFLAGS, I think they have to be added to...

There's still plenty of TODOs in the code (including several of the issues listed here) that seem like fine things to work on. Other bite-sized-ish priorities could include: - Getting...