instance-manager

instance-manager copied to clipboard

We recently added AMI label for nodes, we should also add LaunchConfig label.

This is especially useful for a user to know that for a given instancegroup, all nodes are using a particular launchconfig.

We should also add LaunchConfig as a tag on specific metrics so it can be queries from Prometheus

This is actually not easily doable, especially in the case of launch template version, which we only know when we create the version, which already contains the userdata and the labels.

Getting only the scaling config name would be doable, but in the case of launch template it's not very helpful since you need the version for it to have any value.

Chicken/egg - userdata contains labels, labels need to contain config name/version

looks like ec2 instances have a tag: aws:ec2launchtemplate:version: 2

which may help with this.