fastman icon indicating copy to clipboard operation
fastman copied to clipboard

Suggestion: set default of maxP to NULL

Open mja opened this issue 3 years ago • 1 comments

Current biobank and meta-GWAS are well-powered enough that almost all will contain a P-value smaller than 1e-14, so there isn't a single value that is sensible default for truncating the Y axis. This PR sets maxP=NULL as the default.

mja avatar Jan 05 '23 13:01 mja

Maybe also this parameter could have a different name since the value it accepts is interpreted as -log(P) and would also depend on the value of the logp argument.

mja avatar Jan 05 '23 14:01 mja