Kaare Hoff Skovgaard
Kaare Hoff Skovgaard
I will need to go proper through the test case changes and compare them to Relay's own output. I am pretty swamped at work at the moment so I cannot...
> Yes, completely agree! It's important that the output is correct. As far as I can tell it is, but I'm relatively new to Relay (and was just immediately annoyed...
@alloy I've ported tons more of the code needed to support classic/compat mode. I've noticed that the classic code is doing some static analysis (which seems like it is not...
@alloy Here's code that can do _something_ for both classic, compat and modern code.
I created some very rudimentary and quite a poor man's solution to figure out if some name is defined in a scope in the code (which seems to be needed...
@alloy I have imported the test fixtures from babel-plugin-relay (modern, classic and compat) and have tried to go through the snapshot results by comparing them to the upstream result. There's...
We can move it to a new repo if you think that would be better, I was actually beginning to wonder if the code should just reside in the same...
I have rebased my changes + made a few more corrections. Initial tests on the example code with this in both modern and compat mode works the same with this...
> I was thinking of putting it in a separate repo more because of the name for the repo and package being different, but I guess the repo could get...
> Oh, this doesn’t sound good. I’m not sure I entirely follow, but it sounds like you’re saying that facebook/relay#2293 as-is wouldn’t work when people use web pack? If so,...