karmada
karmada copied to clipboard
karmada-io
Skip schedule deleting bindings
What type of PR is this? /kind feature
What this PR does / why we need it: we should skip schedule deleting bindings cause it makes no sense.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 53.30%. Comparing base (
2220124) to head (ad8ecba).
| Files | Patch % | Lines |
|---|---|---|
| pkg/scheduler/scheduler.go | 0.00% | 8 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #4985 +/- ##
==========================================
- Coverage 53.33% 53.30% -0.04%
==========================================
Files 252 252
Lines 20482 20490 +8
==========================================
- Hits 10924 10922 -2
- Misses 8836 8846 +10
Partials 722 722
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 53.30% <0.00%> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
