karmada icon indicating copy to clipboard operation
karmada copied to clipboard

nominate infra owners

Open RainbowMango opened this issue 1 year ago • 4 comments

What type of PR is this?

This PR nominates @liangyuanpeng @zhzhuang-zju as the owners of infrastructure. @liangyuanpeng and @zhzhuang-zju contributed a lot to improve the infrastructure, such as :

  • Introduced dependabot for automated dependency management
  • Introduced trivy for security scanning
  • Maintains test matrix
  • And so on.

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/hold for current owners to vote and approval /assign @ikaven1024 @lfbear @mrlihanbo

RainbowMango avatar May 24 '24 03:05 RainbowMango

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.33%. Comparing base (f414fa0) to head (073d169).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4984      +/-   ##
==========================================
- Coverage   53.34%   53.33%   -0.01%     
==========================================
  Files         252      252              
  Lines       20482    20482              
==========================================
- Hits        10926    10925       -1     
  Misses       8835     8835              
- Partials      721      722       +1     
Flag Coverage Δ
unittests 53.33% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 24 '24 04:05 codecov-commenter

/lgtm /approve

ikaven1024 avatar May 24 '24 06:05 ikaven1024

/lgtm

lfbear avatar May 24 '24 08:05 lfbear

We've got 2/3 approval from current infra approvers. Thank you all for the support.

/hold cancel /approve

RainbowMango avatar May 28 '24 02:05 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ikaven1024, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar May 28 '24 02:05 karmada-bot