karmada
karmada copied to clipboard
karmada-io
add binding dependencies distributor finalizer to the independent binding
What type of PR is this?
/kind feature
What this PR does / why we need it:
In dependencies distributor module, we need to deal with independent binding cleanup with the right pattern -- control with finalizer, so I add a new finalizer karmada.io/binding-dependencies-distributor.
In addition, in the issue #1741, we can see that the label value of resourcebinding.karmada.io/depended-by-xxx will exceed 63 characters, we need to use the binding permanent ID to replace it, this also prompts us to use finalizer to clean up resources.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Codecov Report
Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.
Project coverage is 53.29%. Comparing base (
d465fcd) to head (89f8a1b).
| Files | Patch % | Lines |
|---|---|---|
| ...ependenciesdistributor/dependencies_distributor.go | 0.00% | 18 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #4983 +/- ##
==========================================
- Coverage 53.34% 53.29% -0.06%
==========================================
Files 252 252
Lines 20481 20495 +14
==========================================
- Hits 10926 10922 -4
- Misses 8834 8851 +17
- Partials 721 722 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 53.29% <0.00%> (-0.06%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
