karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Published 20 hours ago • verified publisher icon karmada-io

Bump golangci-lint to v1.58.0

Open zhzhuang-zju opened this issue 1 year ago • 3 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: Bump golangci-lint to v1.58.0. The following tasks are included：

  • Update the golangci-lint version in hack/verify-staticcheck.sh
  • The configuration option run.skip-dirs is deprecated, use issues.exclude-dirs instead.
  • The configuration option run.skip-dirs-use-default is deprecated, use issues.exclude-dirs-use-default instead.
  • Fix newly scanned errors

Which issue(s) this PR fixes: Fixes #4907

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

zhzhuang-zju avatar May 11 '24 08:05 zhzhuang-zju

since this is the last task, so i think you can fix the issue with fixes #4907

liangyuanpeng avatar May 11 '24 08:05 liangyuanpeng

Codecov Report

Attention: Patch coverage is 34.88372% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 53.19%. Comparing base (4ccffcc) to head (309c677).

Files Patch % Lines
pkg/util/helper/predicate.go 69.23% 4 Missing :warning:
pkg/controllers/status/common.go 0.00% 3 Missing :warning:
pkg/karmadactl/token/token.go 0.00% 0 Missing and 3 partials :warning:
...acefuleviction/crb_graceful_eviction_controller.go 0.00% 2 Missing :warning:
...racefuleviction/rb_graceful_eviction_controller.go 0.00% 2 Missing :warning:
...controllers/unifiedauth/unified_auth_controller.go 0.00% 2 Missing :warning:
operator/pkg/util/util.go 50.00% 1 Missing :warning:
...ionfailover/crb_application_failover_controller.go 0.00% 1 Missing :warning:
...tionfailover/rb_application_failover_controller.go 0.00% 1 Missing :warning:
...ers/binding/cluster_resource_binding_controller.go 0.00% 1 Missing :warning:
... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4930   +/-   ##
=======================================
  Coverage   53.18%   53.19%           
=======================================
  Files         252      252           
  Lines       20510    20510           
=======================================
+ Hits        10909    10911    +2     
+ Misses       8882     8880    -2     
  Partials      719      719
Flag Coverage Δ
unittests 53.19% <34.88%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 11 '24 08:05 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar May 15 '24 09:05 karmada-bot