karmada
karmada copied to clipboard
karmada-io
Generate work permanent id in webhook
What type of PR is this? /kind cleanup
What this PR does / why we need it: Since the PR(https://github.com/karmada-io/karmada/pull/4474) has been merged, we're going to remove those codes which generate work permanent ID outside of webhook.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.17%. Comparing base (
4ccffcc) to head (93a04cb).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #4928 +/- ##
==========================================
- Coverage 53.18% 53.17% -0.01%
==========================================
Files 252 252
Lines 20510 20508 -2
==========================================
- Hits 10909 10906 -3
Misses 8882 8882
- Partials 719 720 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 53.17% <ø> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This breaks version compatibility, it is recommended to add releast-note for this.
@liangyuanpeng The feature version that enables work permanent ID has not been released yet.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
