karmada icon indicating copy to clipboard operation
karmada copied to clipboard

add e2e for FederatedHPA and metrics-adapter

Open chaosi-zju opened this issue 1 year ago • 6 comments

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

add e2e for FederatedHPA and metrics-adapter.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


chaosi-zju avatar May 06 '24 12:05 chaosi-zju

@chaunceyjiang can you help reviewing this PR?

chaosi-zju avatar May 06 '24 12:05 chaosi-zju

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.17%. Comparing base (4ccffcc) to head (b3ccd3b).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
- Coverage   53.18%   53.17%   -0.02%     
==========================================
  Files         252      252              
  Lines       20510    20510              
==========================================
- Hits        10909    10906       -3     
- Misses       8882     8884       +2     
- Partials      719      720       +1     
Flag Coverage Δ
unittests 53.17% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 06 '24 12:05 codecov-commenter

ready

cc @RainbowMango

chaosi-zju avatar May 10 '24 10:05 chaosi-zju

cc test owners /assign @XiShanYongYe-Chang @Vacant2333

RainbowMango avatar May 11 '24 02:05 RainbowMango

@XiShanYongYe-Chang comments all fixed.

chaosi-zju avatar May 11 '24 10:05 chaosi-zju

/approve

RainbowMango avatar May 13 '24 02:05 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar May 13 '24 02:05 karmada-bot