karmada

karmada copied to clipboard

What would you like to be added: There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

• Native resource
  • [ ] GroupVersion: apps/v1 Kind:
    • [x] Deployment @veophi #4867
    • [ ] DaemonSet @whitewindmills
    • [ ] StatefulSet @liangyuanpeng
• Thirdparty resource
  • [ ] GroupVersion: apps.kruise.io/v1alpha1 Kind:
    • [ ] CloneSet @veophi #5057
    • [ ] DaemonSet
  • [ ] GroupVersion: apps.kruise.io/v1beta1 Kind:
    • [ ] StatefulSet @zhy76 #5094
  • [ ] GroupVersion: helm.toolkit.fluxcd.io/v2beta1 Kind:
    • [ ] HelmRelease @Akash-Singh04
  • [ ] GroupVersion: kustomize.toolkit.fluxcd.io/v1 Kind:
    • [ ] Kustomization @yike21 #5084
  • [ ] GroupVersion: source.toolkit.fluxcd.io/v1 Kind:
    • [ ] GitRepository @yike21 #5086
  • [ ] GroupVersion: source.toolkit.fluxcd.io/v1beta2 Kind:
    • [ ] Bucket
    • [ ] HelmChart
    • [ ] HelmRepository
    • [ ] OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

@yike21: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

What would you like to be added: There are some third-party resources and native resources that need to align .metadata.generation and .status.observedGeneration fields. Please ref to #4866 .

Why is this needed:

Continue the work of #4867 and break down the tasks to be done.

• native resource
• [ ] GroupVersion: apps/v1 kind:
  • [ ] Deployment @veophi #4867
  • [ ] DaemonSet
  • [ ] StatefulSet
• Thirdparty resource
• [ ] GroupVersion: apps.kruise.io/v1alpha1 kind:
  • [ ] CloneSet
  • [ ] DaemonSet
• [ ] GroupVersion: apps.kruise.io/v1beta1 kind:
  • [ ] StatefulSet
• [ ] GroupVersion: helm.toolkit.fluxcd.io/v2beta1 kind:
  • [ ] HelmRelease
• [ ] GroupVersion: kustomize.toolkit.fluxcd.io/v1 kind:
  • [ ] Kustomization
• [ ] GroupVersion: source.toolkit.fluxcd.io/v1 kind:
  • [ ] GitRepository
• [ ] GroupVersion: source.toolkit.fluxcd.io/v1beta2 kind:
  • [ ] Bucket
  • [ ] HelmChart
  • [ ] HelmRepository
  • [ ] OCIRepository

We need to examine the meaning of .metadata.generation and .status.observedGeneration fields for each resource above, and then modify the ReflectStatus and AggregateStatus operations to align them. The modifications are likely to be similar, so please wait for CloneSet and Deployment modifications to be completed.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I want to try it for StatefulSet

I want to try it for StatefulSet

Thanks a lot~

@yike21 Good Job!

I wanna pick up DaemonSet, thanks.

I wanna pick up DaemonSet, thanks.

ok, thanks a lot~

I am also concerned about this question. What is the current progress of cloneset? I can get involved in this issue about other resource, too

It will continue to advance in the next version.

Hello everyone, we can continue this issue. @veophi @yike21 @whitewindmills @liangyuanpeng

Hey is this issue still open? if so, I would like to work on it

Hey is this issue still open? if so, I would like to work on it

Thanks! you can choose what you are interested in.

Can I work on apps.kruise.io/v1beta1 statefulset?

Can I work on apps.kruise.io/v1beta1 statefulset?

ok, thanks a lot~

Can we get started on this issue or should we wait for #5057 to be completed? I would like to work on helm.toolkit.fluxcd.io/v2beta1

Can we get started on this issue or should we wait for #5057 to be completed? I would like to work on helm.toolkit.fluxcd.io/v2beta1

Thanks, let's start this issue! We need to modify AggregateStatus and statusReflection, then update testdata to characterize the new customizations.

Hello everyone, we can continue this issue. @veophi @yike21 @whitewindmills @liangyuanpeng

I will open a PR for StatefulSet in this week.

/reopen as closed by #5196 by mistake.

@RainbowMango: Reopened this issue.

In response to this:

/reopen as closed by #5196 by mistake.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Kind ping @Akash-Singh04, do you have time to make a PR?

Hi @yike21, we have one sub-mission left.

Hi @yike21, we have one sub-mission left.

Hi @XiShanYongYe-Chang ! Let's wait a little bit for @Akash-Singh04 . If Akash-Singh04 is busy, I'll finish this part as soon as possible during the week.

Hey @XiShanYongYe-Chang Currently busy, feel free to make a PR :)

It seems all tasks are done. Great job! @yike21 Thanks to everyone who contribute to this task. /close

@RainbowMango: Closing this issue.

In response to this:

It seems all tasks are done. Great job! @yike21 Thanks to everyone who contribute to this task. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Thank you all for the contributions!