karmada
karmada copied to clipboard
karmada-io
bugfix: generate event if reporting condition to karmada failed
What type of PR is this?
/kind bug
What this PR does / why we need it:
service-name-resolution-detector-example, which is introduced in #4646 , requires a kubeconfig to control plane to report conditions to karmada. If kubeconfig is invalid or expired, reporting will fail and events are needed to inform user.
Which issue(s) this PR fixes: Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign garrybest after the PR has been reviewed.
You can assign the PR to them by writing /assign @garrybest in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.78%. Comparing base (
ff7322a) to head (2845c39).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #4763 +/- ##
==========================================
- Coverage 51.79% 51.78% -0.02%
==========================================
Files 250 250
Lines 24991 24991
==========================================
- Hits 12945 12941 -4
- Misses 11337 11340 +3
- Partials 709 710 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 51.78% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
