karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Published 20 hours ago • verified publisher icon karmada-io

complete the e2e test case scenarios for clusterpp

Open zhzhuang-zju opened this issue 1 year ago • 4 comments

What type of PR is this? /kind failing-test

What this PR does / why we need it: complete the e2e test case scenarios for clusterpp. Additional scenes include:

  • Deployment propagation testing create a ClusterPropagationPolicy for deployment and then update deployment replicas
  • [ImplicitPriority] propagation testing priority: MatchName>MatchLabel>MatchAll
  • delete the old ClusterPropagationPolicy to unbind and create a new one(namespace scope and cluster scope)

Which issue(s) this PR fixes: parts of # 4544

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

zhzhuang-zju avatar Jan 23 '24 12:01 zhzhuang-zju

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign xishanyongye-chang after the PR has been reviewed. You can assign the PR to them by writing /assign @xishanyongye-chang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jan 23 '24 12:01 karmada-bot

cc @Vacant2333 @XiShanYongYe-Chang

zhzhuang-zju avatar Jan 24 '24 02:01 zhzhuang-zju

Hi @Vacant2333, can you help take a review? /assign @Vacant2333

XiShanYongYe-Chang avatar Jan 27 '24 08:01 XiShanYongYe-Chang

@XiShanYongYe-Chang looks good to me /lgtm

Vacant2333 avatar Feb 05 '24 12:02 Vacant2333

New changes are detected. LGTM label has been removed.

karmada-bot avatar Mar 20 '24 08:03 karmada-bot

Hi @zhzhuang-zju, can you help rebase the master branch and push again?

XiShanYongYe-Chang avatar Jul 15 '24 01:07 XiShanYongYe-Chang

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.26%. Comparing base (d3adcf6) to head (d43a119). Report is 41 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4575      +/-   ##
==========================================
+ Coverage   28.23%   28.26%   +0.02%     
==========================================
  Files         632      632              
  Lines       43712    43732      +20     
==========================================
+ Hits        12344    12359      +15     
- Misses      30465    30472       +7     
+ Partials      903      901       -2
Flag Coverage Δ
unittests 28.26% <ø> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 15 '24 03:07 codecov-commenter

/retest Oddly, the e2e test has been failing episodically quite frequently lately.

zhzhuang-zju avatar Jul 16 '24 03:07 zhzhuang-zju

cc @XiShanYongYe-Chang @Vacant2333

zhzhuang-zju avatar Jul 18 '24 12:07 zhzhuang-zju

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jul 24 '24 02:07 karmada-bot