karmada
karmada copied to clipboard
karmada-io
do not switch context when deploy karmada
What type of PR is this?
/kind feature
What this PR does / why we need it:
Do not switch context when deploy karmada
Which issue(s) this PR fixes: Fixes #2059
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Welcome @wangyanzhao! It looks like this is your first PR to karmada-io/karmada 🎉
Hi @wangyanzhao, thanks for your contributions.
Please sign off refer to https://github.com/karmada-io/karmada/pull/2091/checks?check_run_id=7112607767
@jameszhangyukun: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@wangyanzhao Testing failed, please check. https://github.com/karmada-io/karmada/runs/7127449610?check_suite_focus=true Seems a typo there.
@wangyanzhao Testing failed, please check. https://github.com/karmada-io/karmada/runs/7127449610?check_suite_focus=true Seems a typo there.
fixed @RainbowMango
@wangyanzhao You might need to add your email to GitHub email list, otherwise, GitHub can't count your contribution.
https://github.com/karmada-io/karmada/runs/7195338380?check_suite_focus=true#step:5:1202
@RainbowMango, it doesn't look like a code bug, can you retry this test.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RainbowMango
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~hack/OWNERS~~ [RainbowMango]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Search Switched to context in action log, still remain some use-context:
https://github.com/karmada-io/karmada/runs/7445487996?check_suite_focus=true#step:4:514
After deploying, shall we change the context to karmada?
The e2e failed due to the current context is not karmada. https://github.com/karmada-io/karmada/runs/7449544501?check_suite_focus=true#step:4:579
After deploying, shall we change the context to karmada?
The e2e failed due to the current context is not karmada. https://github.com/karmada-io/karmada/runs/7449544501?check_suite_focus=true#step:4:579
We shall not switch context, I will fix this e2e test.
After deploying, shall we change the context to karmada? The e2e failed due to the current context is not karmada. https://github.com/karmada-io/karmada/runs/7449544501?check_suite_focus=true#step:4:579
We shall not switch context, I will fix this e2e test.
What do you think about it @RainbowMango?
What do you think about it @RainbowMango?
Do you mean we can't or inappropriate to update the E2E? I haven't looked at the logs.
What do you think about it @RainbowMango?
Do you mean we can't or inappropriate to update the E2E? I haven't looked at the logs.
During deploying, context cannot be change. I green with it. After deploy, shall we change the context? If we change it, it is ready, and maybe wonderful for user to use it. I am not sure about it.
What do you think about it @RainbowMango?
Do you mean we can't or inappropriate to update the E2E? I haven't looked at the logs.
During deploying, context cannot be change. I green with it. After deploy, shall we change the context? If we change it, it is ready, and maybe wonderful for user to use it. I am not sure about it.
I have a case, we should modify our ci shells which is on host cluster because of switch to karmada context after deploying karmada.
WDYT @RainbowMango @ikaven1024
Hi @wangyanzhao shall we move forward it? It seems still some wrong in e2e test.
@wangyanzhao Thanks for doing this. @ikaven1024 picked your commit to #2474, your contribution is counted.