dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

Added usePagination CustomHook and TableWithPagination component

Open ShwetKhatri2001 opened this issue 3 years ago • 2 comments

What type of PR is this? /kind feature

What this PR does / why we need it: This PR includes a reusable function/custom-hook to generate pagination for all types of data on different pages. Also, it includes an example of how to include it with data. The example shows how table data can be divided into pages and shown dynamically based on the page number. It is the implementation of this Figma Design ( Overview Page - iteration 7 frame ).

This PR is also using the DataTable component included in the last PR with some modifications to attach pagination for data in a table.

Which issue(s) this PR fixes: It's a general component useful for different pages of the entire application.

Special notes for your reviewer: @RainbowMango I'm attaching a preview and video link to show how the functionality of pagination included with the table works. We can use the pagination component similarly on any page for any usecase in future.

TablePagination

Video : https://www.loom.com/share/a1ab8e5047a74535a6cb601a2c99295d

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: ShwetKhatri2001 [email protected]

ShwetKhatri2001 avatar Sep 10 '22 20:09 ShwetKhatri2001

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Sep 10 '22 20:09 karmada-bot

@chinmaym07 Do you think this PR is ready to move forward?

RainbowMango avatar Sep 13 '22 01:09 RainbowMango

/close Now we are currently refactoring it on master.

RainbowMango avatar Sep 30 '24 03:09 RainbowMango

@RainbowMango: Closed this PR.

In response to this:

/close Now we are currently refactoring it on master.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot avatar Sep 30 '24 03:09 karmada-bot