kcli
kcli copied to clipboard
cli: ssh_vm() function refactor
This removes some duplicated code and make it a bit more readable.
Signed-off-by: Guillaume Abrioux [email protected]
there s a bit of debate on whether if not x is really the same as if x is None (see https://towardsdatascience.com/python-the-boolean-confusion-f7fc5288f0ce for instance), but regardless, i find the semantic x is None to be easier to read
there s a bit of debate on whether if not x is really the same as if x is None (see https://towardsdatascience.com/python-the-boolean-confusion-f7fc5288f0ce for instance), but regardless, i find the semantic x is None to be easier to read
It's not the only goal of this patch so if you prefer the semantic x is None I can revert those changes.
Otherwise, no sweat, feel free to close this PR if you estimate this refactor isn't worthwhile :slightly_smiling_face:
closing because too much time went (my fault really so sorry about that), feel free to reopen with something more specific