react-swipeable-tabs icon indicating copy to clipboard operation
react-swipeable-tabs copied to clipboard

Tabs are cut off after resize

Open Pustelto opened this issue 8 years ago • 5 comments

Hi,

I'm using your plugin together with react-swipable-views to create swipable tabs and I like your plugin a lot. I have encounter problem with resizing window. When I resize the window the position of tabs is not recalculated correctly which leads to cutoff tabs even when there is enough space to show them all (see pic below).

screen shot 2017-07-19 at 09 40 03

Could you please check it out? Or If you would be interested I could have a look and submit PR (not sure when I will get to this though).

Thanks

Pustelto avatar Jul 19 '17 07:07 Pustelto

Hi Tomas,

Thanks for your email. I'm glad that you liked this plugin. I built it for one of my projects and I think I noticed this issue. I will check it out later tonight and push a fix but can you please open an issue on github just to keep track.

Best, Kareem

On Wed, Jul 19, 2017 at 9:39 AM, Tomas Pustelnik [email protected] wrote:

Hi,

I'm using your plugin together with react-swipable-views to create swipable tabs and I like your plugin a lot. I have encounter problem with resizing window. When I resize the window the position of tabs is not recalculated correctly which leads to cutoff tabs even when there is enough space to show them all (see pic below).

[image: screen shot 2017-07-19 at 09 37 07] https://user-images.githubusercontent.com/10606260/28355804-e03ca492-6c65-11e7-8e1f-89293d3d0796.png

Could you please check it out? Or If you would be interested I could have a look and submit PR (not sure when I will get to this though).

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitriddler/react-swipeable-tabs/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUww4wP7rruNP54oyiUGspHdUgp_RzFks5sPbK2gaJpZM4OcV22 .

kareemaly avatar Jul 19 '17 09:07 kareemaly

Thanks for quick reply and for the effort.

Pustelto avatar Jul 19 '17 10:07 Pustelto

I have pushed a fix for this issue 00bea82427a447495b1b483d18fcc1ebd405c035

Please update to version @2.1.0 and let me know if it works so I can close this issue

kareemaly avatar Jul 20 '17 09:07 kareemaly

Will check it out. Thanks.

Pustelto avatar Jul 20 '17 13:07 Pustelto

So I have checked to issue with the new 2.2.0 version and it is still there. Problem seems to be connected with the translate property on wrapper div element (see pic). After resize of the window this should be recalculated but it isn't and the tabs are still acting like they have the previous size.

screen shot 2017-07-21 at 10 31 03

Pustelto avatar Jul 21 '17 08:07 Pustelto