launchy

launchy copied to clipboard

Im wondering if there is a specific reason for panicking when encountering an unexpected midi value

https://github.com/kangalio/launchy/blob/3e1510d4ba80aee3bd86c4e13fab2cbbca6a6b5d/src/launchpad_mini/input.rs#L71

For context: this is the launchpad mini (mk1), with the example version inquiry code from readme

Dec 23 '23 10:12 lucemans

Hmm it appears [128, x, 64] is sent by the launchpad on release of a button, where X = 0 for the most topleft gridbutton x = 16 for the first button the row below, etc

Dec 23 '23 10:12 lucemans

Cc @belak who contributed Launchpad Mini support in #3

Yeah 128 = 0x80 is the status code for a MIDI note off message. In the code it explained there is no handler for note off messages because the Launchpad doesn't use it... which is evidently false in this case

Dec 23 '23 10:12 kangalio

Happy to make a PR where possible. I currently have a semi-patched version on lucemans/launchy.

Also working on mini mk3 support, but after some testing it has proven to be a lot more difficult seeing it has "scenes" and ableton specific things built in by default.

Dec 23 '23 11:12 lucemans

Created an issue with my findings so far related to the mini mk3

Looking forward to working on this! https://github.com/kangalio/launchy/issues/12

Dec 23 '23 12:12 lucemans

Interesting. I'm not sure why I didn't run into this when I was working on LP Mini support. I can try and take a look in the next few days.

Dec 23 '23 16:12 belak