driver.js icon indicating copy to clipboard operation
driver.js copied to clipboard

How to customize high-lite style to add radius

Open suneethar opened this issue 6 years ago • 6 comments

Currently I am not seeing any configuration to style to high-lite, only for popover class is taken, how can i style the highlite, I want it be round than square.

suneethar avatar May 21 '19 08:05 suneethar

The highlight box have this selector #driver-highlighted-element-stage but unfortunately I tired to add border-radius but didn't work since outline affect such a style.

ghost avatar May 21 '19 20:05 ghost

I am able to override the style using #driver-highlighted-element-stage. But I dint find any configuration to pass class to the highlighted div. I don't want to override using #driver-highlighted-element-stage. Like popover is taking class, I was searching for highlighted div also. So that tomorrow if id name changes, there is no changes required in the application

suneethar avatar May 22 '19 06:05 suneethar

@kamranahmedse Do you want me to send a PR to add a className for this element? If yes, do you have some specific name for that added configuration? or any notes in general

ghost avatar May 22 '19 07:05 ghost

Thanks for the quick replay. Yes, I don't have any specific name for it, you can say it as highlitedClassName or whatever make sense for the user to understand.

suneethar avatar May 22 '19 07:05 suneethar

Is this still open? I feel like a whole lot of new APIs can be created to provide customization of the pop-over and highlight section. Eg: User can pass CSS through JS for both Pop-over & Highlight through 2 options during the driver creation. This will give 100% freedom for the user to decide how he wants to customize the overall driver.js experience.

vishwanathovi avatar May 29 '19 06:05 vishwanathovi

Waiting for @kamranahmedse sign. I may prefer to style by the id selector without making the API bigger to keep it simple IMO

ghost avatar May 29 '19 07:05 ghost

We now have stageRadius option for this.

Also, we just released v1.0 of driver.js which has been rewritten from the ground up. Please have a look at the docs and do let me know if you face any issues.

kamranahmedse avatar Jul 05 '23 17:07 kamranahmedse