Konstantin Maslyuk

Results 32 comments of Konstantin Maslyuk

Hm, @jaakristioja this change is atomic, i see no way to split it without violating the integrity of the code on each commit ((

1. Is something should be removed from here. 3. Would be good duplicate code for stability, but here i m not sure that preserving old logics while adding similar to...

@jaakristioja Hhh, it have to be `const` as well https://github.com/bibletime/bibletime/blob/03387c9b62f26f09a332e0b69bffee70c221a03b/src/backend/keys/cswordkey.h#L89 . And i do not sure why `setIntros(true)` is not set in constructor.

Sorry cant test on GerHfa2002 as it is locked, but InfoDisplay should render range crossreferences now. Linked related PR.

It look like another problem, my linked PR fixes only range keys, so we have to investigate more.

@jaakristioja or someone here) not sure, why crossreferences in ISV are rendered as `Rendering::Reference` and not as `Rendering::CrossReference`, that support parsing for verse list from reference (first one - don't)....

Yes. But i d still rely on automatic formatter for 95% of cases and do manual fixes as needed. It follows from your message that there is no actual code...

> Since you want to merge it into wip/kalemas/fix-verse-range-rendering-in-info is suppose this depends on pull request #362? Yes, i m sure it require changes from that PR but for review...

@jaakristioja i think that this may be reviewed now. I would say fair, i see no problems with passing by pointer/references, constancy. I also split main commit in two that...

it is now rendered correctly at my sight ![image](https://user-images.githubusercontent.com/638393/149681002-39ad5c38-d49e-444f-b451-ce5a41f0c5a0.png)