commitplease icon indicating copy to clipboard operation
commitplease copied to clipboard

Skip links for the length rule

Open markelog opened this issue 7 years ago • 5 comments

Sometimes it's preferable to use links which might be longer then assigned limit, you do have the rules – markerPattern, actionPattern, ticketPattern, but it's intended for the issues and it's a bit convoluted to use.

It would be nice if you could auto-detect the links and skip them without introducing additional configuration properties

markelog avatar Apr 28 '18 13:04 markelog

I think the combination of "Ref [long URL]" is already accepted. Can you give that a try?

jzaefferer avatar Apr 29 '18 08:04 jzaefferer

Sure, I guess, feels a bit awkward though. Like

feat: Kill the gorilla

Killed big gorilla here (https://en.wikipedia.org/wiki/Gorilla) 
with the double-edged blade

In such case I would have to restructure commit message to make it proper. I envision it like ignoreUrls of max-length rule of the eslint

markelog avatar May 04 '18 11:05 markelog

feat: Kill the gorilla

Killed big gorilla with the double-edged blade

Ref https://en.wikipedia.org/wiki/Gorilla

That's not so bad, is it?

jzaefferer avatar May 04 '18 12:05 jzaefferer

Not saying it is, look above

Regards, Oleg

On 4 May 2018, at 15:06, Jörn Zaefferer [email protected] wrote:

feat: Kill the gorilla

Killed big gorilla with the double-edged blade

Ref https://en.wikipedia.org/wiki/Gorilla That's not so bad, is it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

markelog avatar May 04 '18 13:05 markelog

I think the combination of "Ref [long URL]" is already accepted.

It's not :)

markelog avatar Oct 24 '18 10:10 markelog