jwt-scala icon indicating copy to clipboard operation
jwt-scala copied to clipboard

add support for scala.js

Open massimosiani opened this issue 3 years ago • 4 comments

Hi, first of all thanks for the project!

I did my best with the modules I know, I'm not sure if the other modules can be supported as well. Are you able to publish a snapshot to verify that everything is in place?

Should close #258.

massimosiani avatar Sep 24 '22 22:09 massimosiani

Hi, did you have the opportunity to have a look at this?

massimosiani avatar Oct 04 '22 06:10 massimosiani

Hi @massimosiani sure, I'll take a look. Thank you for your contribution!

It's a big PR and it's a big investment to decide to maintain the lib for JS as well going forward, so I want to take the time to go through it.

erwan avatar Oct 04 '22 07:10 erwan

You can do a publishLocal to publish to your local machine repository to test it

erwan avatar Oct 04 '22 07:10 erwan

Hi @erwan, thanks for the reply. Ofc, take your time, I was only wondering if that's a good addition. If you end up not taking the burden to maintain that (and that's totally understandable from my pov!), I'll look for some way to publish some sort of wrapped version if you don't mind. If I can convince you, please also consider that AWS Lambda functions are pretty popular, so more and more scala libs are cross compiling to scalajs (and lately to scala native). Thanks again for the project!

massimosiani avatar Oct 04 '22 08:10 massimosiani

@erwan @massimosiani Any updates on this? I'm also looking for JWT parser on scalajs, and this lib would be a nice fit.

2chilled avatar Feb 05 '23 16:02 2chilled

:tada: @erwan @massimosiani thank you!

2chilled avatar Feb 13 '23 09:02 2chilled

hey @massimosiani and @2chilled ,

I published v9.2.0 with the PR merged but I'm not sure the publication of the ScalaJS artifacts was successful. Could you take a look and tell me if it works?

erwan avatar Feb 15 '23 21:02 erwan

  • https://github.com/jwt-scala/jwt-scala/issues/451

xuwei-k avatar Feb 18 '23 22:02 xuwei-k