jupyterlab-vim icon indicating copy to clipboard operation
jupyterlab-vim copied to clipboard

Allow for disabling extension

Open mlucool opened this issue 5 years ago • 7 comments

Thanks for the work on this!

While this may be an odd request, can we add a way to enable/disable this extension? In my case, we want to share an app-dir between users, so we plan to install this for everyone, but want to give user a way to opt in.

We could add a user preference, which may be the simplest option. We could also have this follow whatever the text editor keymap choice is. That feels cleaner, but I am not sure if its possible.

mlucool avatar Nov 01 '19 22:11 mlucool

@jwkvam if I do this, will you have time to review/merge/release? I ask as it seems there are a few PRs stalled here and want to be sure this project is still active

mlucool avatar Dec 24 '19 19:12 mlucool

I'm also interested in knowing what this project's outlook is. @jwkvam, I'm really grateful your work on this tool, but I get the sense that you might be too busy to maintain this, which is totally fine, and you owe us nothing. If that's true, and there is someone with the bandwidth to take over (which is not me), would you be ok with someone else maintaining the project?

benlindsay avatar Dec 24 '19 21:12 benlindsay

@mlucool I would suggest starting to work on this if/when you have bandwidth for it. Worst case scenario, if @jwkvam isn't able to respond, we should eventually think about forking this project. The ability to turn the extension on and off is super useful, so your work wouldn't go to waste however this ends up going

benlindsay avatar Dec 24 '19 22:12 benlindsay

I have created https://github.com/jwkvam/jupyterlab-vim/pull/112

mlucool avatar Jan 22 '20 20:01 mlucool

@benlindsay Given the inactivity, did you want to fork this somewhere and maintain it?

mlucool avatar Feb 19 '20 19:02 mlucool

I don't have the bandwidth to do that, so no, but it would be great if you or someone else could.

On Wed, Feb 19, 2020, 1:47 PM Marc Udoff [email protected] wrote:

@benlindsay https://github.com/benlindsay Given the inactivity, did you want to fork this somewhere and maintain it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jwkvam/jupyterlab-vim/issues/106?email_source=notifications&email_token=ACHNOAAFPRPVYRDFEOQOGT3RDWEGHA5CNFSM4JIAPK42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJH2HI#issuecomment-588414237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHNOAGFMI6N4JE4SGQUSCLRDWEGHANCNFSM4JIAPK4Q .

benlindsay avatar Feb 23 '20 13:02 benlindsay

I submitted a PR for this (#76) over a year ago but never got a response from @jwkvam. I agree this repo no longer seems to be maintained.

jlumpe avatar Feb 25 '20 19:02 jlumpe