Matt Sicker
Matt Sicker
Initial PR done: https://github.com/spinnaker/kork/pull/1138 Will follow up with some Fiat changes to complete the abstraction.
The builder updates are related to adding dependency-injected values. I did not include any concrete implementations of the metrics API yet, but I updated some areas that are supposed to...
Or to be more specific, instead of creating yet another global variable, I had to refactor some code to apply inversion of control a little bit. If we were adapting...
What sort of event would be published here that could correspond to a counter? That's a push-based mechanism itself.
Looking through https://opentelemetry.io/docs/specs/otel/logs/ and OTel in general, it seems like we should have support for some of this directly. I don't think we need to implement all the APIs (like...
I think that's a good idea.
I think I've proposed something along these lines in the past, but it seemed like too much work at the time. However, I love this idea in general. It would...
Some initial thoughts about this: * Configuration files or configuration code have the ability to execute arbitrary code by using custom plugins; as such, configurations must be controlled by the...
Yes, I covered that point in > Advanced methods of handling configuration (such as a refresh period for the config file, JMX remote management, or other remote methods for updating...
For one, I just noticed that `immediateFlush` isn't even used in `RollingFileAppender` despite being an option. Let's see what else is broken because of this >_>