task-spooler icon indicating copy to clipboard operation
task-spooler copied to clipboard

Make cpu_only a make/cmake toggle and drop the cpu_only branch ?

Open AdelKS opened this issue 3 years ago • 3 comments

Hello!

To simplify packaging (I want to write an ebuild for Gentoo's GURU) so the code given in the releases tarballs can be used directly, it would be awesome if you could merge the cpu_only into master and make it into a cmake toggle for example, and/or maybe make the GPU queuing a toggle. Is it very difficult for you ? Another option is to add the cpu_only source code to the releases.

Thanks!

Adel

AdelKS avatar Mar 09 '22 16:03 AdelKS

Hi @AdelKS. It's a good idea. The first option is what I have been longing for. However, I suppose it will require some restructuring of the codes, which currently I cannot find time for. The second option is can be a short-term solution, but doing so will lose all history of the cpu-only branch. Btw, there is a tar ball for the cpu-only branch in each release (for e.g., here. Is it not what you need?

justanhduc avatar Mar 10 '22 05:03 justanhduc

Thanks for your answer! Good luck!

Btw, there is a tar ball for the cpu-only branch in each release (for e.g., here. Is it not what you need?

I did not see it as I only checked the "Releases" page and not the tags, that one is good yes ! Thank you

AdelKS avatar Mar 10 '22 11:03 AdelKS

Hey @AdelKS. Finally I could merge the two branches together! Please check out the latest master. Maybe it's not stable for now, but so far I haven't encountered any problem.

justanhduc avatar Aug 24 '22 07:08 justanhduc

Hello @justanhduc, sorry for the late answer, I was busy with other projects ! :D

Okay, I tried to compile master and unfortunately I cannot see a cmake toggle to disable GPU support, and I get this error message:

CMake Error at /usr/share/cmake/Modules/CMakeDetermineCUDACompiler.cmake:180 (message):
  Failed to find nvcc.

  Compiler requires the CUDA toolkit.  Please set the CUDAToolkit_ROOT
  variable.

AdelKS avatar Sep 18 '22 12:09 AdelKS

Hi @AdelKS. I will investigate it. But I think installing using make should work because it is the main method I use during development while CMake is a bit an afterthought. Please try installing via make. Thanks for noticing me this problem!

justanhduc avatar Sep 21 '22 03:09 justanhduc