jupyter-server-proxy icon indicating copy to clipboard operation
jupyter-server-proxy copied to clipboard

Published 20 hours ago • verified publisher icon jupyterhub

Move proxy_request_options to configuration.

Open ryanlovett opened this issue 6 years ago • 6 comments

To address #112.

ryanlovett avatar Mar 18 '19 05:03 ryanlovett

Example app that requires a proxy request option: https://github.com/ryanlovett/jupyter-syncthing

ryanlovett avatar Mar 18 '19 06:03 ryanlovett

This is awesome, and we should definitely support configuring timeouts. However, I think we should explicitly support them, since otherwise we will be tied down to Tornado's HTTP Client implementation. I'd love to move to aiohttp at some point.

yuvipanda avatar Apr 28 '19 08:04 yuvipanda

Hello, thank you for your effort.

I need to configure jupyterhub proxy timeouts (without monkey-patching the code preferably).

I'll just wait for this to be merged, right?

It cannot take long, definitely under half a year, right?

costa avatar Sep 23 '19 09:09 costa

@costa Are you able to help test this?

manics avatar Sep 23 '19 10:09 manics

@manics Let's see, I'm using the JupyterHub helm chart with a custom-built singleuser image which is built with installing jupyter-server-proxy through pip; I guess I can install a custom version of that to produce a test image to use with a test JupyterHub deployment — if it is not too much effort to do so.

costa avatar Sep 23 '19 14:09 costa

Guys (no assumption here ;)), this PR has conflicts, I'm probably willing to test this if I have a chance to change the proxy request timeout without having to monkey-patch the code myself — and anyone can (fix the conflicts and) confirm it's worth the effort.

costa avatar Sep 26 '19 12:09 costa