julienrbrt

Results 245 comments of julienrbrt

Yes 100% agree, we are going to use struct annotations and `github.com/pelletier/go-toml/v2` library for server/v2: https://github.com/cosmos/cosmos-sdk/blob/605b724/server/v2/api/grpc/config.go#L19-L34 I don't think it makes sense to refactor the server v0 config.

Could you please point me where you see a missing field between the config.go and the toml.go? I cannot find any. Removing the bug label as it is more a...

> > Could you please point me where you see a missing field between the config.go and the toml.go? I cannot find any. Removing the bug label as it is...

This is perfect, thank you!

As per our standup, we'll keep using testify and won't refactor it away in existing touched tests. Existing packages using `gotest.tools` can stay as they are. Testify suites should still...

Looking at the original PR, seems like Secret abandoned the feature. Given the pushback closing this then 👍

> docs are scattered across different files ([In-Place Store Migrations](https://docs.cosmos.network/v0.44/core/upgrade.html), [Upgrading Modules](https://docs.cosmos.network/v0.44/building-modules/upgrade.html), [Migrations Section](https://docs.cosmos.network/v0.44/migrations/chain-upgrade-guide-044.html), [Upgrade Module spec](https://docs.cosmos.network/v0.44/modules/upgrade/), [Cosmovisor](https://docs.cosmos.network/v0.44/run-node/cosmovisor.html#detecting-upgrades)) Few notes on the that, as I just skimmed the migration docs:...

IMHO, Ignite shouldn't overwrite user settings, especially messing with user space by setting environment variable. As @ilgooz said, this setting is enabled by default in recent Go versions and as...

This is still valid: ```go (main ✓) gm ignite s message create-post foo bar modify proto/gm/gm/tx.proto create x/gm/keeper/msg_server_create_post.go modify x/gm/module/autocli.go modify x/gm/module/simulation.go create x/gm/simulation/create_post.go modify x/gm/types/codec.go create x/gm/types/message_create_post.go create x/gm/types/message_create_post_test.go...