Julien Fontanet

Results 174 comments of Julien Fontanet

I just took a quick glance, but putting an `if (builtInDefaults)` around these two lines appear to do the job: https://github.com/jorgebucaran/getopts/blob/35dfad8997697051234aca992eb90c7abd7a5465/index.js#L189-L190

After a quick test, it seems that by default, `yargs` does not set default values to boolean/string/number options.

@natevw Hey I'm looking into it but I have to say that I don't see how to do it, would it possible for you to give me a small example?...

> Sorry been busy with other projects and I have to admit I'm myself rusty on the details of this library. No problem, I'm also rather busy, I'll take a...

You should be able to use the dynamic syntax: ``` javascript stopLightColor['default'](function () { return 'unknown'; }); ```

The problem can appear though if trying to lock files on different fs with different precisions. Maybe that should be a separate issue though.

> the precision can vary when locking different paths that are associated with different file systems, is that correct? Yep. IMHO, those duplicate calls to `Object.defineProperty` are incorrect but it...

@satazor AFAU, the problem comes from the test expecting a specific number of calls to `stat`: https://github.com/moxystudio/node-proper-lockfile/blob/9f8c303c91998e8404a911dc11c54029812bca69/test/lock.test.js#L193 But the new algorithm, introduce an extra to get the device.

My 2 cents: - `ms` is usually used for durations, not for dates, so I don't think it's a big issue that it does not correspond exactly to the current...

https://github.com/julien-f/kneden-stage-0