niftyplugins icon indicating copy to clipboard operation
niftyplugins copied to clipboard

Published 20 hours ago • verified publisher icon jtilander

NiftyPerforce - VS 2019 Compatibility

Open jgvincen opened this issue 6 years ago • 7 comments

Added support for building/running Nifty Perforce with Visual Studio 2019. Added partial support for loading the Nifty Perforce extension in the background.

jgvincen avatar Oct 02 '19 09:10 jgvincen

Looks great. Terribly sorry though, my employer prevents me from doing any open source.

jtilander avatar Oct 03 '19 04:10 jtilander

I understand, I wouldn't want to make trouble. Are you allowed to approve/reject code changes which you didn't write?

jgvincen avatar Oct 03 '19 04:10 jgvincen

Works4Me. Perhaps @belkiss could merge?

benh57 avatar Oct 16 '19 00:10 benh57

Works4Me. Perhaps @belkiss could merge?

Heya! I can't merge this here since I don't have permissions :) My fork https://github.com/belkiss/niftyplugins has had support for vs2019 for a while now, but I didn't make the changes for async load, so I'll try and integrate those changes there!

Thanks for the heads-up :)

belkiss avatar Oct 16 '19 06:10 belkiss

Hey @belkiss! If it's not a ton of trouble could you make a new release with all your fixes in it? I'd super appreciate it

akamboj avatar Oct 21 '19 22:10 akamboj

I've integrated the changes, they work great! https://github.com/belkiss/niftyplugins/commit/3e27df8da017a462136384d5835b66845225002d

Hey @belkiss! If it's not a ton of trouble could you make a new release with all your fixes in it? I'd super appreciate it

I'll try and setup the CI so we can release vsix, I'll keep you posted :)

belkiss avatar Oct 22 '19 10:10 belkiss

Glad to hear that someone picked up my change. So, I guess @belkiss's fork has become the unofficial new mainline?

jgvincen avatar Oct 24 '19 08:10 jgvincen