Jeffrey Stedfast

Okay, so I'll drop the `.failures`. That still doesn't answer the most important question which is should these instruments (Counters/Histograms) be per-instance or global?

Just to bookmark this for myself, this is the code for metrics reporting in HttpClient: * https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Metrics/SocketsHttpHandlerMetrics.cs * https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs

Updated list of metrics for SmtpClient: ## SmtpClient Metrics ### Metric: `mailkit.net.smtp.client.connect.count` | **Name** | **Instrument Type** | **Unit** | **Description** | |:-------------------------------------------|:--------------------|:----------------|:---------------------------------------------------------------------------| | `mailkit.net.smtp.client.connect.count` | Counter | `{attempt}` |...

> You should be very careful with tags with high cardinality: like IP and hostname. These might cause strain on the metrics database which may lead to degraded performance on...

I could probably kill the `connect.count` and `send.count` metrics, right? We could keep `connect.duration` and maybe kill the `socket.error` and `smtp.status_code` tags and just leave `error.type` (but maybe rename to...

I'm just curious, but is anyone wanting tracing and metrics (and logging?) from MailKit doing anything but SMTP?

Let us take a moment to rewind a bit and take a step back and discuss what is actually needed because I think I'm perhaps overengineering this based on how...

How much, in terms of allocations, does the ImapTokenCache save us? No cache (for comparison):  With this PR (cache capacity = 128):  capacity = 256: 

I've actually been thinking of doing this for the past year or so, it's just hard to find the time to work on it. I was also hoping to see...

Can you get a protocol log and zip it up and send it to me? I need the BOMs to be in the log so that I can write up...