atom-terminal-tab

atom-terminal-tab copied to clipboard

Add alt-shift-t keybinding to open terminal. It allows non mac user to open terminal with keybinding.

It could help with #6 if we remove cmd-shift-t.

+1 for platform-agnostic keybindings

Agree that cmd-shift-t is probably not a good default, although that is what I would choose to map personally. We shouldn't clobber existing conventions out of the box, though.

I noticed that they keybinding-resolver package uses these CSS classes to do platform-specific bindings:

{
  ".platform-darwin": {
    "cmd-.": "key-binding-resolver:toggle"
  },
  ".platform-win32": {
    "ctrl-.": "key-binding-resolver:toggle"
  },
  ".platform-linux": {
    "ctrl-.": "key-binding-resolver:toggle"
  }
}

I wonder if we could do something similar?

as proposed by @daviwil I added platform specific bindings, it doesn't change anything for mac users, cmd-shift-t still open terminal instead of reopening last closed tab.

alt-shift-t open terminal for windows/linux users to avoid introducing #6 on windows/linux

I'm going to address this in #66. Would you mind rebasing this PR on that branch? I'll merge it there and probably make a bunch of changes for Windows and Mac, as well.

@jsmecham rebased on #66 and copy/paste conflicts fixed

What's the status of this?